[PWGCF] Adding the option to reject half the FT0 #14
Conversation
github-actions
bot
changed the title
There was a problem hiding this comment.
Pull request overview
This PR adds configuration switches to selectively exclude (reject) FT0A/FT0C inner- and outer-ring channels when building TPC–FT0 correlations, enabling eta-dependent studies with partial FT0 acceptance.
Changes:
- Added new configurables to reject FT0A/FT0C inner/outer ring channels.
- Introduced FT0 channel range constants (inner/outer, A/C) to support the rejection logic.
- Applied the rejection during the FT0 channel loop in
fillCorrelationsTPCFT0().
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| int chanelid = 0; | ||
| float ampl = 0.; | ||
| getChannel(ft0, iCh, chanelid, ampl, corType); | ||
| if (corType == kFT0C) { | ||
| if ((cfgRejectFT0CInside && (chanelid >= kFT0CInnerRingMin && chanelid <= kFT0CInnerRingMax)) || (cfgRejectFT0COutside && (chanelid >= kFT0COuterRingMin && chanelid <= kFT0COuterRingMax))) { | ||
| continue; | ||
| } | ||
| } else if (corType == kFT0A) { | ||
| if ((cfgRejectFT0AInside && (chanelid >= kFT0AInnerRingMin && chanelid <= kFT0AInnerRingMax)) || (cfgRejectFT0AOutside && (chanelid >= kFT0AOuterRingMin && chanelid <= kFT0AOuterRingMax))) { | ||
| continue; | ||
| } | ||
| } |
There was a problem hiding this comment.
When rejection is enabled, the code still calls getChannel() (which fills FT0Amp/FT0AmpCorrect and applies gain correction) before checking whether the channel will be rejected. This adds avoidable work inside the track×channel nested loop and also means the FT0Amp QA histograms still include channels that are “rejected”. Consider checking the channel id/range before calling getChannel(), or moving the rejection logic into getChannel() so rejected channels are skipped/zeroed consistently and without extra fills.
| int chanelid = 0; | |
| float ampl = 0.; | |
| getChannel(ft0, iCh, chanelid, ampl, corType); | |
| if (corType == kFT0C) { | |
| if ((cfgRejectFT0CInside && (chanelid >= kFT0CInnerRingMin && chanelid <= kFT0CInnerRingMax)) || (cfgRejectFT0COutside && (chanelid >= kFT0COuterRingMin && chanelid <= kFT0COuterRingMax))) { | |
| continue; | |
| } | |
| } else if (corType == kFT0A) { | |
| if ((cfgRejectFT0AInside && (chanelid >= kFT0AInnerRingMin && chanelid <= kFT0AInnerRingMax)) || (cfgRejectFT0AOutside && (chanelid >= kFT0AOuterRingMin && chanelid <= kFT0AOuterRingMax))) { | |
| continue; | |
| } | |
| } | |
| // Use preliminary channel id derived from index to perform rejection | |
| int chanelid = static_cast<int>(iCh); | |
| if (corType == kFT0C) { | |
| if ((cfgRejectFT0CInside && (chanelid >= kFT0CInnerRingMin && chanelid <= kFT0CInnerRingMax)) || | |
| (cfgRejectFT0COutside && (chanelid >= kFT0COuterRingMin && chanelid <= kFT0COuterRingMax))) { | |
| continue; | |
| } | |
| } else if (corType == kFT0A) { | |
| if ((cfgRejectFT0AInside && (chanelid >= kFT0AInnerRingMin && chanelid <= kFT0AInnerRingMax)) || | |
| (cfgRejectFT0AOutside && (chanelid >= kFT0AOuterRingMin && chanelid <= kFT0AOuterRingMax))) { | |
| continue; | |
| } | |
| } | |
| float ampl = 0.; | |
| // Only retrieve channel information (and trigger its QA) for non-rejected channels | |
| getChannel(ft0, iCh, chanelid, ampl, corType); |
| int chanelid = 0; | ||
| float ampl = 0.; | ||
| getChannel(ft0, iCh, chanelid, ampl, corType); | ||
| if (corType == kFT0C) { | ||
| if ((cfgRejectFT0CInside && (chanelid >= kFT0CInnerRingMin && chanelid <= kFT0CInnerRingMax)) || (cfgRejectFT0COutside && (chanelid >= kFT0COuterRingMin && chanelid <= kFT0COuterRingMax))) { |
There was a problem hiding this comment.
Variable name chanelid looks like a typo and makes the new rejection logic harder to read/grep. Consider renaming to channelId (and adjusting related uses) for clarity.
1 participant
Adding the option to reject half of the FT0 detectors to eta dependent studies